Add an error-checking wc_curve25519_make_pub() routine to the API for use by Wireguard #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xisting private key, using bare vectors."; rename existing _LOCAL functions wc_curve25519_GetBasePoint() and wc_curve25519() to nxp_ltc_curve25519_GetBasePoint() and nxp_ltc_curve25519() respectively; add const qualifiers opportunistically to existing _LOCAL function curve25519()
… nxp_ltc_curve25519().
dgarske
requested changes
Aug 6, 2020
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Excellent addition! I built against NXP K82 and found a few issues.
…s correct curve25529_bCurveParam) introduced in aadec34.
…_KEYSIZE, not CURVE25519_KEY_SIZE; add static kCurve25519BasePoint at top level
…curve25519_bCurveParam)
dgarske
approved these changes
Aug 6, 2020
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Thanks. Builds correctly for K82 LTC now. Don't have hardware to test on but it does fix an outstanding build error for it.
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
For the new function go ahead and add in a test case. This could be to either wolfcrypt/test/test.c or to tests/api.c.
…wc_curve25519(), for clarity and consistency (hat tip to Jacob).
douzzer
changed the title
…bs; remove weird extra string-terminating null in test_wolfSSL_sk_CIPHER_description().
…rve25519_make_pub().
…complete the pair. also, add call to fe_init() in the non-NXP codepath of wc_curve25519_make_pub() (note fe_init() is currently a no-op).
dgarske
approved these changes
Aug 7, 2020
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Thanks Douzzer, this is a great addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose an error-checking wc_curve25519() routine for use by Wireguard, and shuffle some names for clarity.